Re: [PATCH V4 02/12] misc: xilinx-sdfec: add core driver

From: Greg KH
Date: Thu Jun 06 2019 - 15:08:19 EST


On Thu, Jun 06, 2019 at 06:16:48PM +0000, Dragan Cvetic wrote:
> >
> > > +
> > > + misc_deregister(&xsdfec->miscdev);
> > > + atomic_dec(&xsdfec_ndevs);
> > > + return 0;
> >
> > You free nothing?
> >
> > You are leaking resources like crazy here, this is not ok at all.
>
> The managed resources are used.
> Anyway, I'll test for memory leak and search for the answer.

Oops, no, you are right, I missed the "devm" prefix on those calls. My
fault.

thanks,

greg k-h