Re: [PATCH] KVM: x86: introduce is_pae_paging

From: Sean Christopherson
Date: Thu Jun 06 2019 - 13:24:44 EST


On Thu, Jun 06, 2019 at 06:52:52PM +0200, Paolo Bonzini wrote:
> Checking for 32-bit PAE is quite common around code that fiddles with
> the PDPTRs. Add a function to compress all checks into a single
> invocation.
>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>

I considered adding this helper as well, but shied away because I thought
it might lead to incorrect code, e.g. using is_pae_paging() when is_pae()
is needed. But, looking at the patch, it's definitely cleaner, so:

Reviewed-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>