Re: [PATCH 2/5] mm/hmm: Clean up some coding style and comments

From: Joe Perches
Date: Thu Jun 06 2019 - 13:00:34 EST


On Thu, 2019-06-06 at 11:52 -0400, Jerome Glisse wrote:
> On Thu, Jun 06, 2019 at 12:41:29PM -0300, Jason Gunthorpe wrote:
> > On Thu, Jun 06, 2019 at 10:27:43AM -0400, Jerome Glisse wrote:
> > > On Thu, Jun 06, 2019 at 11:16:44AM -0300, Jason Gunthorpe wrote:
> > > > On Mon, May 06, 2019 at 04:29:39PM -0700, rcampbell@xxxxxxxxxx wrote:
> > > > > From: Ralph Campbell <rcampbell@xxxxxxxxxx>
> > > > >
> > > > > There are no functional changes, just some coding style clean ups and
> > > > > minor comment changes.
> > > > >
> > > > > Signed-off-by: Ralph Campbell <rcampbell@xxxxxxxxxx>
> > > > > Reviewed-by: Jérôme Glisse <jglisse@xxxxxxxxxx>
> > > > > Cc: John Hubbard <jhubbard@xxxxxxxxxx>
> > > > > Cc: Ira Weiny <ira.weiny@xxxxxxxxx>
> > > > > Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> > > > > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > > > > Cc: Balbir Singh <bsingharora@xxxxxxxxx>
> > > > > Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > > > > Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>
> > > > > Cc: Souptick Joarder <jrdr.linux@xxxxxxxxx>
> > > > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > > > include/linux/hmm.h | 71 +++++++++++++++++++++++----------------------
> > > > > mm/hmm.c | 51 ++++++++++++++++----------------
> > > > > 2 files changed, 62 insertions(+), 60 deletions(-)
> > > >
> > > > Applied to hmm.git, thanks
> > >
> > >
> > > Can you hold off, i was already collecting patches and we will
> > > be stepping on each other toe ... for instance i had
> >
> > I'd really rather not, I have a lot of work to do for this cycle and
> > this part needs to start to move forward now. I can't do everything
> > last minute, sorry.
> >
> > The patches I picked up all look very safe to move ahead.
>
> I want to post all the patch you need to apply soon, it is really
> painful because they are lot of different branches i have to work
> with if you start pulling patches that differ from the below branch
> then you are making thing ever more difficult for me.
>
> If you hold of i will be posting all the patches in one big set so
> that you can apply all of them in one go and it will be a _lot_
> easier for me that way.

Easier for you is not necessarily easier for a community.
Publish early and often.