Re: [PATCH RFC 03/10] mm/gup: Pass flags down to __gup_device_huge* calls

From: Ira Weiny
Date: Thu Jun 06 2019 - 12:13:43 EST


On Wed, Jun 05, 2019 at 11:18:19PM -0700, Christoph Hellwig wrote:
> On Wed, Jun 05, 2019 at 06:45:36PM -0700, ira.weiny@xxxxxxxxx wrote:
> > From: Ira Weiny <ira.weiny@xxxxxxxxx>
> >
> > In order to support checking for a layout lease on a FS DAX inode these
> > calls need to know if FOLL_LONGTERM was specified.
> >
> > Prepare for this with this patch.
>
> The GUP fast argument passing is a mess. That is why I've come up
> with this as part of the (not ready) get_user_pages_fast_bvec
> implementation:
>
> http://git.infradead.org/users/hch/misc.git/commitdiff/c3d019802dbde5a4cc4160e7ec8ccba479b19f97

Agreed that looks better.

And I'm sure I will have to re-roll this to deal with conflicts with this set.
But for now I needed this for the follow ons and having a nice separate little
patch like this means I can just drop it after I get your clean up! :-D

Ira