Re: [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver

From: Shenhar, Talel
Date: Thu Jun 06 2019 - 03:30:19 EST



On 6/5/2019 6:12 PM, Marc Zyngier wrote:
On 05/06/2019 15:38, Shenhar, Talel wrote:

FIC only support two sensing modes, rising-edge and level.
Yes, I can tell. Yet, this code will let EDGE_BOTH pass through, even if
it cannot handle it.
Will handle on v4
Indeed we use interrupt specifier that has the level type in it
(dt-binding: "#interrupt-cells: must be 2.") which in turns causes to
this irq_set_type callback.
Well, this isn't what the example in your DT binding shows.
Will update the example in v4


Thanks,

Talel.