RE: [PATCH v2 2/3] scsi: ufs: Allow resetting the UFS device

From: Avri Altman
Date: Thu Jun 06 2019 - 02:40:35 EST



> static int ufshcd_hba_init(struct ufs_hba *hba)
> {
> int err;
> @@ -7425,9 +7460,15 @@ static int ufshcd_hba_init(struct ufs_hba *hba)
> if (err)
> goto out_disable_vreg;
>
> + err = ufshcd_init_device_reset(hba);
> + if (err)
> + goto out_disable_variant;
> +
> hba->is_powered = true;
> goto out;
>
> +out_disable_variant:
> + ufshcd_vops_setup_regulators(hba, false);
Is this necessary?
ufshcd_vops_setup_regulators() was just called as part of ufshcd_variant_hba_init

Thanks,
Avri