Re: [PATCH RESEND V4 2/3] arm64: dts: imx8qxp: Move watchdog node into scu node

From: Shawn Guo
Date: Wed Jun 05 2019 - 02:04:21 EST


On Tue, Jun 04, 2019 at 09:06:28AM +0000, Anson Huang wrote:
> Hi, Shawn
> The driver and binding doc are already reviewed and waiting for DT patch, will you help review this DT patch?

I'm fine with it. Should I just pick this patch up, or is there any
dependency we need to handle?

Shawn

>
> Thanks,
> Anson
>
> > -----Original Message-----
> > From: Anson Huang
> > Sent: Sunday, May 12, 2019 6:11 PM
> > To: robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; wim@xxxxxxxxxxxxxxxxxx;
> > linux@xxxxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
> > kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; Aisheng Dong
> > <aisheng.dong@xxxxxxx>; ulf.hansson@xxxxxxxxxx; Daniel Baluta
> > <daniel.baluta@xxxxxxx>; Peng Fan <peng.fan@xxxxxxx>;
> > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> > watchdog@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Cc: dl-linux-imx <linux-imx@xxxxxxx>
> > Subject: [PATCH RESEND V4 2/3] arm64: dts: imx8qxp: Move watchdog node
> > into scu node
> >
> > i.MX system controller watchdog has pretimeout function which depends on
> > i.MX SCU driver, so it should be a subnode of SCU.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > ---
> > No change, just resend patch with correct encoding.
> > ---
> > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > index 0683ee2..b17c22e 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > @@ -149,6 +149,11 @@
> > rtc: rtc {
> > compatible = "fsl,imx8qxp-sc-rtc";
> > };
> > +
> > + watchdog {
> > + compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
> > + timeout-sec = <60>;
> > + };
> > };
> >
> > timer {
> > @@ -517,9 +522,4 @@
> > power-domains = <&pd IMX_SC_R_GPIO_7>;
> > };
> > };
> > -
> > - watchdog {
> > - compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
> > - timeout-sec = <60>;
> > - };
> > };
> > --
> > 2.7.4
>