Re: [PATCH v5 2/3] arch/arm64: fpsimd: Introduce fpsimd_save_and_flush_cpu_state() and use it

From: Catalin Marinas
Date: Tue Jun 04 2019 - 07:16:31 EST


On Tue, May 21, 2019 at 06:21:38PM +0100, Julien Grall wrote:
> The only external user of fpsimd_save() and fpsimd_flush_cpu_state() is
> the KVM FPSIMD code.
>
> A following patch will introduce a mechanism to acquire owernship of the
> FPSIMD/SVE context for performing context management operations. Rather
> than having to export the new helpers to get/put the context, we can just
> introduce a new function to combine fpsimd_save() and
> fpsimd_flush_cpu_state().
>
> This has also the advantage to remove any external call of fpsimd_save()
> and fpsimd_flush_cpu_state(), so they can be turned static.
>
> Lastly, the new function can also be used in the PM notifier.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> Reviewed-by: Dave Martin <Dave.Martin@xxxxxxx>
[...]
> ---
> arch/arm64/include/asm/fpsimd.h | 4 +---
> arch/arm64/kernel/fpsimd.c | 17 +++++++++++++----
> arch/arm64/kvm/fpsimd.c | 4 +---
> 3 files changed, 15 insertions(+), 10 deletions(-)

Marc, since this touches KVM, can I get an ack on this patch? I plan to
queue the series.

Thanks.

--
Catalin