Re: [PATCH v6 17/19] mips: Add support for generic vDSO

[Mark Salyzyn]

On 05/31/2019 01:34 AM, Arnd Bergmann wrote:
> On Thu, May 30, 2019 at 4:16 PM Vincenzo Frascino
> <vincenzo.frascino@xxxxxxx> wrote:
>
> > --- a/arch/mips/vdso/vdso.lds.S
> > +++ b/arch/mips/vdso/vdso.lds.S
> > @@ -99,6 +99,10 @@ VERSION
> >          global:
> >                  __vdso_clock_gettime;
> >                  __vdso_gettimeofday;
> > +               __vdso_clock_getres;
> > +#if _MIPS_SIM != _MIPS_SIM_ABI64
> > +               __vdso_clock_gettime64;
> > +#endif
> >   #endif
> >          local: *;
> >          };
> Same comment as for the corresponding arm change: I'd leave the ABI
> changes to a separate patch, and probably not add __vdso_clock_getres
> at all.

Removing this would break ABI (would it really, it just replaces the 
syscall ... so it is more of a user space expectation)? already present 
in arm64 before this series.

-- Mark