Re: [PATCH 03/10] arm64: dts: meson-gxbb-wetek: enable SARADC

From: Neil Armstrong
Date: Wed May 29 2019 - 10:21:24 EST


On 27/05/2019 20:15, Martin Blumenstingl wrote:
> On Mon, May 27, 2019 at 3:22 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>>
>> From: Christian Hewitt <christianshewitt@xxxxxxxxx>
>>
>> Enable SARADC on Wetek Boards.
> as far I as remember there's a story behind this (and it would be nice
> to have it documented here):
> some of the SCPI firmware revisions don't enable the SAR ADC clock
> when reading the SoCs temperature.
> if the SAR ADC is disabled in Linux then the common clock framework
> will disable the SAR ADC clock.
> now, when the SCPI firmware uses the SAR ADC to read the SoC
> temperature we only get garbage.
>
> enabling the SAR ADC in Linux "fixes" this issue

Yes seems to be this issue solved here

>
>> Signed-off-by: Christian Hewitt <christianshewitt@xxxxxxxxx>
>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> with that:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>