Re: [PATCH v2] video: fbdev: atmel_lcdfb: add COMPILE_TEST support

From: kbuild test robot
Date: Fri May 24 2019 - 10:03:23 EST

Next message: Kirill Tkhai: "Re: [PATCH v2 0/7] mm: process_vm_mmap() -- syscall for duplication a process mapping"
Previous message: Parav Pandit: "[PATCHv4 2/3] vfio/mdev: Avoid creating sysfs remove file on stale device removal"
In reply to: kbuild test robot: "Re: [PATCH v2] video: fbdev: atmel_lcdfb: add COMPILE_TEST support"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Bartlomiej,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.2-rc1 next-20190524]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Bartlomiej-Zolnierkiewicz/video-fbdev-atmel_lcdfb-add-COMPILE_TEST-support/20190524-184331
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

sparse warnings: (new ones prefixed by >>)

>> drivers/video/fbdev/atmel_lcdfb.c:354:27: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected char [noderef] <asn:2> *screen_base @@ got n:2> *screen_base @@
>> drivers/video/fbdev/atmel_lcdfb.c:354:27: sparse: expected char [noderef] <asn:2> *screen_base
>> drivers/video/fbdev/atmel_lcdfb.c:354:27: sparse: got void *
>> drivers/video/fbdev/atmel_lcdfb.c:362:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *s @@ got char [noderef] <asvoid *s @@
>> drivers/video/fbdev/atmel_lcdfb.c:362:9: sparse: expected void *s
>> drivers/video/fbdev/atmel_lcdfb.c:362:9: sparse: got char [noderef] <asn:2> *screen_base
>> drivers/video/fbdev/atmel_lcdfb.c:333:59: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected void *cpu_addr @@ got char [noderef] <asvoid *cpu_addr @@
>> drivers/video/fbdev/atmel_lcdfb.c:333:59: sparse: expected void *cpu_addr
drivers/video/fbdev/atmel_lcdfb.c:333:59: sparse: got char [noderef] <asn:2> *screen_base
>> drivers/video/fbdev/atmel_lcdfb.c:333:59: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected void *cpu_addr @@ got char [noderef] <asvoid *cpu_addr @@
>> drivers/video/fbdev/atmel_lcdfb.c:333:59: sparse: expected void *cpu_addr
drivers/video/fbdev/atmel_lcdfb.c:333:59: sparse: got char [noderef] <asn:2> *screen_base

vim +354 drivers/video/fbdev/atmel_lcdfb.c

14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 328
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 329 static inline void atmel_lcdfb_free_video_memory(struct atmel_lcdfb_info *sinfo)
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 330 {
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 331 struct fb_info *info = sinfo->info;
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 332
f6e45661 drivers/video/fbdev/atmel_lcdfb.c Luis R. Rodriguez 2016-01-22 @333 dma_free_wc(info->device, info->fix.smem_len, info->screen_base,
f6e45661 drivers/video/fbdev/atmel_lcdfb.c Luis R. Rodriguez 2016-01-22 334 info->fix.smem_start);
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 335 }
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 336
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 337 /**
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 338 * atmel_lcdfb_alloc_video_memory - Allocate framebuffer memory
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 339 * @sinfo: the frame buffer to allocate memory for
1d01e835 drivers/video/atmel_lcdfb.c Krzysztof Helt 2009-07-08 340 *
1d01e835 drivers/video/atmel_lcdfb.c Krzysztof Helt 2009-07-08 341 * This function is called only from the atmel_lcdfb_probe()
1d01e835 drivers/video/atmel_lcdfb.c Krzysztof Helt 2009-07-08 342 * so no locking by fb_info->mm_lock around smem_len setting is needed.
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 343 */
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 344 static int atmel_lcdfb_alloc_video_memory(struct atmel_lcdfb_info *sinfo)
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 345 {
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 346 struct fb_info *info = sinfo->info;
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 347 struct fb_var_screeninfo *var = &info->var;
ea757aca drivers/video/atmel_lcdfb.c Haavard Skinnemoen 2008-08-12 348 unsigned int smem_len;
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 349
ea757aca drivers/video/atmel_lcdfb.c Haavard Skinnemoen 2008-08-12 350 smem_len = (var->xres_virtual * var->yres_virtual
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 351 * ((var->bits_per_pixel + 7) / 8));
ea757aca drivers/video/atmel_lcdfb.c Haavard Skinnemoen 2008-08-12 352 info->fix.smem_len = max(smem_len, sinfo->smem_len);
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 353
f6e45661 drivers/video/fbdev/atmel_lcdfb.c Luis R. Rodriguez 2016-01-22 @354 info->screen_base = dma_alloc_wc(info->device, info->fix.smem_len,
f6e45661 drivers/video/fbdev/atmel_lcdfb.c Luis R. Rodriguez 2016-01-22 355 (dma_addr_t *)&info->fix.smem_start,
f6e45661 drivers/video/fbdev/atmel_lcdfb.c Luis R. Rodriguez 2016-01-22 356 GFP_KERNEL);
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 357
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 358 if (!info->screen_base) {
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 359 return -ENOMEM;
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 360 }
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 361
01d3a5e7 drivers/video/atmel_lcdfb.c Haavard Skinnemoen 2008-04-28 @362 memset(info->screen_base, 0, info->fix.smem_len);
01d3a5e7 drivers/video/atmel_lcdfb.c Haavard Skinnemoen 2008-04-28 363
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 364 return 0;
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 365 }
14340586 drivers/video/atmel_lcdfb.c Nicolas Ferre 2007-05-10 366

:::::: The code at line 354 was first introduced by commit
:::::: f6e45661f9be546811b62b2b01f32f4bf0c436c0 dma, mm/pat: Rename dma_*_writecombine() to dma_*_wc()

:::::: TO: Luis R. Rodriguez <mcgrof@xxxxxxxx>
:::::: CC: Ingo Molnar <mingo@xxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Next message: Kirill Tkhai: "Re: [PATCH v2 0/7] mm: process_vm_mmap() -- syscall for duplication a process mapping"
Previous message: Parav Pandit: "[PATCHv4 2/3] vfio/mdev: Avoid creating sysfs remove file on stale device removal"
In reply to: kbuild test robot: "Re: [PATCH v2] video: fbdev: atmel_lcdfb: add COMPILE_TEST support"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]