Re: [PATCH v2] ppp: deflate: Fix possible crash in deflate_init

From: David Miller
Date: Tue May 14 2019 - 18:44:22 EST


From: YueHaibing <yuehaibing@xxxxxxxxxx>
Date: Tue, 14 May 2019 22:55:32 +0800

> BUG: unable to handle kernel paging request at ffffffffa018f000
...
> If ppp_deflate fails to register in deflate_init,
> module initialization failed out, however
> ppp_deflate_draft may has been regiestred and not
> unregistered before return.
> Then the seconed modprobe will trigger crash like this.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> v2: also check ppp_deflate_draft registration

Applied and queued up for -stable, thanks.