Re: [PATCH] vsprintf: Do not break early boot with probing addresses

From: Geert Uytterhoeven
Date: Tue May 14 2019 - 05:04:09 EST


On Tue, May 14, 2019 at 10:29 AM David Laight <David.Laight@xxxxxxxxxx> wrote:
> > And I like Steven's "(fault)" idea.
> > How about this:
> >
> > if ptr < PAGE_SIZE -> "(null)"
> > if IS_ERR_VALUE(ptr) -> "(fault)"
> >
> > -ss
>
> Or:
> if (ptr < PAGE_SIZE)
> return ptr ? "(null+)" : "(null)";
> if IS_ERR_VALUE(ptr)
> return "(errno)"

Do we care about the value? "(-E%u)"?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds