Re: [PATCH] drm/panfrost: Only put sync_out if non-NULL

From: Rob Herring
Date: Mon May 13 2019 - 10:58:04 EST


On Thu, May 9, 2019 at 3:22 AM Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx> wrote:
>
> Dan Carpenter's static analysis tool reported:
>
> drivers/gpu/drm/panfrost/panfrost_drv.c:222 panfrost_ioctl_submit()
> error: we previously assumed 'sync_out' could be null (see line 216)
>
> Indeed, sync_out could be NULL if userspace doesn't send a sync object
> ID for the out fence.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Link: https://lists.freedesktop.org/archives/dri-devel/2019-May/217014.html
> ---
> drivers/gpu/drm/panfrost/panfrost_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Applied.

Rob