[PATCH 2/2] pinctrl: stmfx: Fix 'warn: bitwise AND condition is false here'

From: Lee Jones
Date: Mon May 13 2019 - 03:36:18 EST


drivers/pinctrl/pinctrl-stmfx.c:441 stmfx_pinctrl_irq_set_type() warn: bitwise AND condition is false here

Reported-by: kbuild test robot <lkp@xxxxxxxxx>
Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
---
drivers/pinctrl/pinctrl-stmfx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
index 074c8fa3e75c..eba872ce4a7c 100644
--- a/drivers/pinctrl/pinctrl-stmfx.c
+++ b/drivers/pinctrl/pinctrl-stmfx.c
@@ -437,7 +437,7 @@ static int stmfx_pinctrl_irq_set_type(struct irq_data *data, unsigned int type)
u32 reg = get_reg(data->hwirq);
u32 mask = get_mask(data->hwirq);

- if (type & IRQ_TYPE_NONE)
+ if (type == IRQ_TYPE_NONE)
return -EINVAL;

if (type & IRQ_TYPE_EDGE_BOTH) {
--
2.17.1