Re: [PATCH] net: qrtr: use protocol endiannes variable

From: David Miller
Date: Fri May 10 2019 - 16:29:30 EST


From: Nicholas Mc Guire <hofrat@xxxxxxxxx>
Date: Fri, 10 May 2019 03:08:53 +0200

> diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
> index dd0e97f..c90edaa 100644
> --- a/net/qrtr/qrtr.c
> +++ b/net/qrtr/qrtr.c
> @@ -733,7 +733,8 @@ static int qrtr_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)
> struct qrtr_node *node;
> struct sk_buff *skb;
> size_t plen;
> - u32 type = QRTR_TYPE_DATA;
> + u32 type = 0;
> + __le32 qrtr_type = cpu_to_le32(QRTR_TYPE_DATA);
> int rc;

Please try to preserve as much of the reverse chrimstas tree here rather
than making it worse.

Thank you.