Re: [PATCH 1/8] sysfs: Add sysfs_update_groups function

From: Greg Kroah-Hartman
Date: Sat May 04 2019 - 09:54:21 EST


On Sat, May 04, 2019 at 02:52:00PM +0200, Jiri Olsa wrote:
> Adding sysfs_update_groups function to update
> multiple groups.
>
> TODO:
>
> I'm not sure how to handle error path in here,
> currently it removes the whole updated group
> together with already existing (not updated)
> attributes.

I think that should be fine. The chance of an error happening here is
really slim.

> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>

Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>