Re: [PATCH v3 4/7] leds: TI LMU: Add common code for TI LMU devices

[Dan Murphy]

Jacek

On 4/30/19 2:32 PM, Jacek Anaszewski wrote:
> On 4/30/19 9:30 PM, Dan Murphy wrote:
>> Randy
>>
>> On 4/30/19 2:23 PM, Randy Dunlap wrote:
>>> On 4/30/19 12:17 PM, Dan Murphy wrote:
>>>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>>>> index da00b9ed5a5c..3ae24eaf4cde 100644
>>>> --- a/drivers/leds/Kconfig
>>>> +++ b/drivers/leds/Kconfig
>>>> @@ -776,6 +776,14 @@ config LEDS_NIC78BX
>>>> ÂÂÂÂÂÂÂ To compile this driver as a module, choose M here: the module
>>>> ÂÂÂÂÂÂÂ will be called leds-nic78bx.
>>>> Â +config LEDS_TI_LMU_COMMON
>>>> +ÂÂÂ tristate "LED driver for TI LMU"
>>>
>>> what does LMU mean?
>>
>> Lighting management unit it is defined in the DT documentation
>>
>>>
>>>> +ÂÂÂ depends on REGMAP
>>>> +ÂÂÂ help
>>>> +ÂÂÂÂÂÂÂÂÂ Say Y to enable the LED driver for TI LMU devices.
>>>> +ÂÂÂÂÂÂÂÂÂ This supports common features between the TI LM3532, LM3631, LM3632,
>>>> +ÂÂÂÂÂ LM3633, LM3695 and LM3697.
>>>
>>> Fix help indentation above to use tab + 2 spaces consistently.
>>>
>>
>> UGH I wish I had this comment 2 weeks ago.
>> But I can fix it
> 
> I will amend this while merging, no need to resend.
> 

Thank you.  I will wait to rebase/repost the LM36274 patchset until after the this series is merged.

Honestly the only change to the LM36274 patchset is adding Rob's RB to the dt patches and rebasing the Kconfig.

Dan