Re: [PATCH] usbip: vhci_hcd: Mark expected switch fall-through

From: Gustavo A. R. Silva
Date: Tue Apr 30 2019 - 13:38:28 EST




On 4/30/19 10:44 AM, Greg Kroah-Hartman wrote:

>>
>> this error message is what makes me think the fall-through is
>> intentional; otherwise I think it would look like this instead:
>>
>> if (hcd->speed != HCD_USB3) {
>> pr_err("USB_PORT_FEAT_U2_TIMEOUT req not "
>> "supported for USB 2.0 roothub\n");
>> goto error;
>> }
>
> I think you are right, that's horrid, but correct :(
>

Yep. :/

> Will go queue this up, thanks.
>

Thanks, Greg.
--
Gustavo