Re: [PATCH 1/5] soc/fsl/qe: qe.c: drop useless static qualifier

From: Christophe Leroy
Date: Tue Apr 30 2019 - 13:03:48 EST




Le 30/04/2019 Ã 15:36, Rasmus Villemoes a ÃcritÂ:
The local variable snum_init has no reason to have static storage duration.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx>

Reviewed-by: Christophe Leroy <christophe.leroy@xxxxxx>

---
drivers/soc/fsl/qe/qe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
index 612d9c551be5..855373deb746 100644
--- a/drivers/soc/fsl/qe/qe.c
+++ b/drivers/soc/fsl/qe/qe.c
@@ -306,7 +306,7 @@ static void qe_snums_init(void)
0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59,
0x68, 0x69, 0x78, 0x79, 0x80, 0x81,
};
- static const u8 *snum_init;
+ const u8 *snum_init;
qe_num_of_snum = qe_get_num_of_snums();