Re: [PATCH 3/4] perf cgroup: Add cgroup ID as a key of RB tree

From: Liang, Kan
Date: Tue Apr 30 2019 - 11:46:28 EST




On 4/30/2019 5:03 AM, Peter Zijlstra wrote:
On Mon, Apr 29, 2019 at 07:44:04AM -0700, kan.liang@xxxxxxxxxxxxxxx wrote:

Add unique cgrp_id for each cgroup, which is composed by CPU ID and css
subsys-unique ID.

*WHY* ?! that doesn't make any kind of sense.. In fact you mostly then
use the low word because most everything is already per CPU.


I tried to assign an unique ID for each cgroup event.
But you are right, it looks like not necessary.
I will remove it.

Thanks,
Kan