Re: [PATCH v7 3/4] s390: ap: implement PAPQ AQIC interception in kernel

From: Halil Pasic
Date: Tue Apr 30 2019 - 05:37:33 EST


On Tue, 30 Apr 2019 10:32:52 +0200
Pierre Morel <pmorel@xxxxxxxxxxxxx> wrote:

> >>> +ÂÂÂ aqic_gisa.gisa = gisa->next_alert >> 4;
> >>
> >> Why gisa->next_alert? Isn't this supposed to get set to gisa origin
> >> (without some bits on the left)?

s/left/right/

> >
> > Someone already asked this question.

It must have been in some previous iteration... Can you give me a
pointer?

> > The answer is: look at the ap_qirq_ctrl structure, you will see that the
> > gisa field is 27 bits wide.

My question was not about the width, but about gisa->next_alert being
used.

Regards,
Halil