RE: [PATCH 3/7] net: stmmac: dma channel control register need to be init first

From: Voon, Weifeng
Date: Mon Apr 29 2019 - 22:49:46 EST


> From: Voon, Weifeng <weifeng.voon@xxxxxxxxx>
> Date: Thu, Apr 25, 2019 at 08:06:08
>
> > > stmmac_init_chan() needs to be called before stmmac_init_rx_chan()
> > > and stmmac_init_tx_chan(). This is because if PBLx8 is to be used,
> > > "DMA_CH(#i)_Control.PBLx8" needs to be set before programming
> > > "DMA_CH(#i)_TX_Control.TxPBL" and "DMA_CH(#i)_RX_Control.RxPBL".
> > >
> > > Reviewed-by: Zhang, Baoli <baoli.zhang@xxxxxxxxx>
> > > Signed-off-by: Weifeng Voon <weifeng.voon@xxxxxxxxx>
> > > Signed-off-by: Ong Boon Leong <boon.leong.ong@xxxxxxxxx>
>
> This is a fix so it should belong to -net tree and it should have the
> "Fixes: " tag.
>
> Thanks,
> Jose Miguel Abreu

Noted. I will add the "Fixes" tag and re-submit to -net tree.

Regards,
Weifeng