Re: [PATCH net-next] netdevsim: fix fall-through annotation

From: Jakub Kicinski
Date: Mon Apr 29 2019 - 20:40:30 EST


On Mon, 29 Apr 2019 12:38:07 -0500, Gustavo A. R. Silva wrote:
> Replace "pass through" with a proper "fall through" annotation
> in order to fix the following warning:
>
> drivers/net/netdevsim/bus.c: In function ânew_device_storeâ:
> drivers/net/netdevsim/bus.c:170:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
> port_count = 1;
> ~~~~~~~~~~~^~~
> drivers/net/netdevsim/bus.c:172:2: note: here
> case 2:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This fix is part of the ongoing efforts to enable
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>

Acked-by: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx>