Re: [PATCH] kernel: remove the unused device_private_entry_fault export

From: Dan Williams
Date: Mon Apr 29 2019 - 10:45:48 EST


On Mon, Apr 29, 2019 at 4:56 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> This export has been entirely unused since it was added more than 1 1/2
> years ago.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> kernel/memremap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/memremap.c b/kernel/memremap.c
> index 4e59d29245f4..1490e63f69a9 100644
> --- a/kernel/memremap.c
> +++ b/kernel/memremap.c
> @@ -45,7 +45,6 @@ vm_fault_t device_private_entry_fault(struct vm_area_struct *vma,
> */
> return devmem->page_fault(vma, addr, page, flags, pmdp);
> }
> -EXPORT_SYMBOL(device_private_entry_fault);
> #endif /* CONFIG_DEVICE_PRIVATE */

Looks good to me.

Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>