Re: [PATCH v2 6/7] mmc: meson-gx: remove Rx phase tuning

From: Martin Blumenstingl
Date: Sat Apr 27 2019 - 16:09:32 EST


On Tue, Apr 23, 2019 at 11:03 AM Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:
>
> This remove all the code related to phase settings. Using the Rx phase
> for tuning has not been reliable. We had several issues over the past
> months, on both v2 and v3 mmc chips After discussing the issue matter
> with Amlogic, They suggested to set a phase shift of 180 between Core and
> Tx and use signal resampling for the tuning.
>
> Since we won't be playing with the phase anymore, let's remove all the
> clock code related to it and set the appropriate value on init.
>
> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
[Khadas VIM now shows the HS200 eMMC]
Tested-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>


BEFORE (no patches from this series applied):
# dmesg | grep mmc1
(no output)

AFTER (all 7 patches from this series applied):
# dmesg | grep mmc1
[ 2.945155] mmc1: new HS200 MMC card at address 0001
[ 2.957737] mmcblk1: mmc1:0001 AWPD3R 14.6 GiB
[ 2.966278] mmcblk1boot0: mmc1:0001 AWPD3R partition 1 4.00 MiB
[ 2.976114] mmcblk1boot1: mmc1:0001 AWPD3R partition 2 4.00 MiB
[ 2.986354] mmcblk1rpmb: mmc1:0001 AWPD3R partition 3 4.00 MiB,
chardev (241:0)


Regards
Martin