Re: [PATCH net-next] net: phy: micrel: make sure the factory test bit is cleared

From: Andrew Lunn
Date: Fri Apr 26 2019 - 12:47:31 EST


On Fri, Apr 26, 2019 at 06:41:23PM +0200, Antoine Tenart wrote:
> The KSZ8081 PHY has a factory test mode which is set at the de-assertion
> of the reset line based on the RXER (KSZ8081RNA/RND) or TXC
> (KSZ8081MNX/RNB) pin. If a pull-down is missing, or if the pin has a
> pull-up, the factory test mode should be cleared by manually writing a 0
> (according to the datasheet). This patch makes sure this factory test
> bit is cleared in config_init().
>
> Tested-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Signed-off-by: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew