Re: [PATCH] stmmac: pci: Adjust IOT2000 matching

[Jan Kiszka]

On 26.04.19 16:34, Andy Shevchenko wrote:
> On Thu, Apr 18, 2019 at 12:15 PM Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
> > From: Su Bao Cheng <baocheng.su@xxxxxxxxxxx>
> >
> > Since there are more IOT2040 variants with identical hardware but
> > different asset tags, the asset tag matching should be adjusted to
> > support them.
> >
> > For the board name "SIMATIC IOT2000", currently there are 2 types of
> > hardware, IOT2020 and IOT2040. The IOT2020 is identified by its unique
> > asset tag. Match on it first. If we then match on the board name only,
> > we will catch all IOT2040 variants. In the future there will be no other
> > devices with the "SIMATIC IOT2000" DMI board name but different
> > hardware.
> >
> > Signed-off-by: Su Bao Cheng <baocheng.su@xxxxxxxxxxx>
> > Reviewed-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>
> > +       /*
>
> > +        * There are 2 types of SIMATIC IOT2000: IOT20202 and IOT2040.
>
> 20202 ?

2020...

I can send a fix-up or v2, whatever is preferred.

Thanks,
Jan

> > +        * The asset tag "6ES7647-0AA00-0YA2" is only for IOT2020 which
> > +        * has only one pci network device while other asset tags are
> > +        * for IOT2040 which has two.
> > +        */

--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux