Re: [PATCH v2 06/15] spi: imx: fix ERR009165

[Lucas Stach]

Am Freitag, den 26.04.2019, 08:05 +0000 schrieb Robin Gong:
> Change to XCHÂÂmode even in dma mode, please refer to the below
> errata:
> https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf
> 
> Signed-off-by: Robin Gong <yibin.gong@xxxxxxx>
> ---
> Âdrivers/spi/spi-imx.c | 11 +++++------
> Â1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index 09c9a1e..eb56eac 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -585,8 +585,9 @@ static int mx51_ecspi_prepare_transfer(struct
> spi_imx_data *spi_imx,
> Â	ctrl |= mx51_ecspi_clkdiv(spi_imx, t->speed_hz, &clk);
> Â	spi_imx->spi_bus_clk = clk;
> Â
> +	/* ERR009165: work in XHC mode as PIO */
> Â	if (spi_imx->usedma)
> -		ctrl |= MX51_ECSPI_CTRL_SMC;
> +		ctrl &= ~MX51_ECSPI_CTRL_SMC;
> Â
> Â	writel(ctrl, spi_imx->base + MX51_ECSPI_CTRL);
> Â
> @@ -612,12 +613,14 @@ static int mx51_ecspi_prepare_transfer(struct
> spi_imx_data *spi_imx,
> Â
> Âstatic void mx51_setup_wml(struct spi_imx_data *spi_imx)
> Â{
> +	u32 tx_wml = 0;
> +

With a wml of 0 you might set the maxburst of the TX dma channel to
fifosize to minimize the performance impact of this workaround.

Regards,
Lucas

> Â	/*
> Â	Â* Configure the DMA register: setup the watermark
> Â	Â* and enable DMA request.
> Â	Â*/
> Â	writel(MX51_ECSPI_DMA_RX_WML(spi_imx->wml - 1) |
> -		MX51_ECSPI_DMA_TX_WML(spi_imx->wml) |
> +		MX51_ECSPI_DMA_TX_WML(tx_wml) |
> Â		MX51_ECSPI_DMA_RXT_WML(spi_imx->wml) |
> Â		MX51_ECSPI_DMA_TEDEN | MX51_ECSPI_DMA_RXDEN |
> Â		MX51_ECSPI_DMA_RXTDEN, spi_imx->base +
> MX51_ECSPI_DMA);
> @@ -1265,10 +1268,6 @@ static int spi_imx_sdma_init(struct device
> *dev, struct spi_imx_data *spi_imx,
> Â{
> Â	int ret;
> Â
> -	/* use pio mode for i.mx6dl chip TKT238285 */
> -	if (of_machine_is_compatible("fsl,imx6dl"))
> -		return 0;
> -
> Â	spi_imx->wml = spi_imx->devtype_data->fifo_size / 2;
> Â
> Â	/* Prepare for TX DMA: */
> --Â
> 2.7.4
>