Re: [PATCHv1 5/6] firmware: rsu: document sysfs interface

From: Greg KH
Date: Thu Apr 25 2019 - 16:27:25 EST


On Tue, Apr 09, 2019 at 01:46:01PM -0500, richard.gong@xxxxxxxxxxxxxxx wrote:
> From: Richard Gong <richard.gong@xxxxxxxxx>
>
> Describe Intel Stratix10 Remote System Update (RSU) device attributes
>
> Signed-off-by: Richard Gong <richard.gong@xxxxxxxxx>
> Reviewed-by: Alan Tull <atull@xxxxxxxxxx>
> ---
> .../testing/sysfs-devices-platform-stratix10-rsu | 78 ++++++++++++++++++++++
> 1 file changed, 78 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-devices-platform-stratix10-rsu
>
> diff --git a/Documentation/ABI/testing/sysfs-devices-platform-stratix10-rsu b/Documentation/ABI/testing/sysfs-devices-platform-stratix10-rsu
> new file mode 100644
> index 0000000..cb461ee
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-devices-platform-stratix10-rsu
> @@ -0,0 +1,78 @@
> + Intel Stratix10 Remote System Update (RSU) device attributes
> +
> +What: /sys/devices/platform/soc:firmware:svc/soc:firmware:svc:rsu/current_image
> +Date: April 2019
> +KernelVersion: 5.2
> +Contact: Richard Gong <richard.gong@xxxxxxxxx>
> +Description:
> + (RO) the address of image currently running in flash.
> +
> +What: /sys/devices/platform/soc:firmware:svc/soc:firmware:svc:rsu/fail_image
> +Date: April 2019
> +KernelVersion: 5.2
> +Contact: Richard Gong <richard.gong@xxxxxxxxx>
> +Description:
> + (RO) the address of failed image in flash.

Use tabs everywhere please, do not mix spaces for some attributes and
tabs for others.

thanks,

gre gk-h