Re: [PATCH] dma-mapping: remove an unnecessary NULL check

From: Christoph Hellwig
Date: Thu Apr 25 2019 - 10:32:55 EST


On Thu, Apr 25, 2019 at 03:31:01PM +0100, Ian Abbott wrote:
> On 25/04/2019 15:18, Christoph Hellwig wrote:
>> On Thu, Apr 25, 2019 at 03:13:49PM +0100, Ian Abbott wrote:
>>> So for comedi_isadma, we can just replace the NULL with a pointer to a
>>> static dummy device with a 24-bit coherent mask?
>>
>> It should be converted to a proper isa_driver, so that it gets a real
>> struct device.
>
> But it will work as a short term solution? comedi_isadma isn't a driver,
> but is used by a few comedi drivers for ISA cards.

Then convert the drivers properly and pass on the device from them.