Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

[Amit Kucheria]

On Thu, Apr 25, 2019 at 6:36 PM Marc Gonzalez <marc.w.gonzalez@xxxxxxx> wrote:
>
> On 25/04/2019 08:31, Amit Kucheria wrote:
>
> > [PATCH 3/3] arm64: dts: msm8998: thermal: Restrict thermal zone name length to under 20
> >
> > The thermal core restricts names of thermal zones to under 20
> > characters. Fix the names for a couple of msm8998 thermal zones.
> >
> > Signed-off-by: Amit Kucheria <amit.kucheria@xxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/msm8998.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> > index 062a93a12198..01757829d5f3 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> > @@ -536,7 +536,7 @@
> >                       };
> >               };
> >
> > -             cluster0-mhm-thermal {
> > +             clust0-mhm-thermal {
> >                       polling-delay-passive = <250>;
> >                       polling-delay = <1000>;
> >
> > @@ -551,7 +551,7 @@
> >                       };
> >               };
> >
> > -             cluster1-mhm-thermal {
> > +             clust1-mhm-thermal {
> >                       polling-delay-passive = <250>;
> >                       polling-delay = <1000>;
> >
>
> Wouldn't it be better to drop the "-thermal" suffix than to chop characters
> off from the actual description?

Probably a good idea, but it will perturb my OCD and cause a large
search and replace to replace all thermal zones names in this series.
:-) I want to keep it consistent across all boards.

I don't think Andy would like that too much.

> Or would it make sense to increase the 20-char limit to 24?
> => Probably impossible without breaking the user-space ABI, since
> THERMAL_NAME_LENGTH is defined in include/uapi/linux/thermal.h

Yes, I abandoned that path quickly after seeing where this was
defined, but I have a follow-on patch to make this a compile-time bug
rather than wondering why the thermal zone failed at runtime.

> Anyway, for msm8998 patches, you have my
>
> Tested-by: Marc Gonzalez <marc.w.gonzalez@xxxxxxx>

Thanks a lot for testing.