Re: [EXT] Re: [PATCH v2] clk: qoriq: Add clockgen support for lx2160a

From: Rafael J. Wysocki
Date: Thu Apr 25 2019 - 06:29:32 EST


On Thu, Apr 25, 2019 at 12:15 PM Andy Tang <andy.tang@xxxxxxx> wrote:
>
>
> > -----Original Message-----
> > From: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> > Sent: 2019å4æ25æ 18:04
> > To: Vabhav Sharma <vabhav.sharma@xxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx;
> > linux-pm@xxxxxxxxxxxxxxx; sboyd@xxxxxxxxxx; mturquette@xxxxxxxxxxxx;
> > rjw@xxxxxxxxxxxxx; viresh.kumar@xxxxxxxxxx; Yogesh Narayan Gaur
> > <yogeshnarayan.gaur@xxxxxxx>; Andy Tang <andy.tang@xxxxxxx>
> > Subject: [EXT] Re: [PATCH v2] clk: qoriq: Add clockgen support for lx2160a
> >
> > Caution: EXT Email
> >
> > On Thu, Apr 25, 2019 at 11:48 AM Vabhav Sharma <vabhav.sharma@xxxxxxx>
> > wrote:
> > >
> > > From: Yogesh Gaur <yogeshnarayan.gaur@xxxxxxx>
> > >
> > > Add clockgen support for lx2160a.
> > > Added entry for compat 'fsl,lx2160a-clockgen'.
> >
> > Well, if I'm expected to apply this, the above is a bit terse.
> >
> > It looks like the patch makes the qoriq-cpufreq driver handle some new
> > hardware, but the changelog doesn't say much about that.
> >
> > I'm guessing that the clockgen support added here makes it possible for
> > qoriq-cpufreq to handle this chip, is that correct?
> Yes, your guess is correct. The cpufreq feature is based on clock driver.
> It should had been separated to two patches and reduced the confuse.
> Do I need to update the commit message or you just take it?

Please update the commit message.

Thanks!