Re: [PATCH v4 04/26] dt-bindings: leds: Add LED_COLOR_ID definitions
From: Jacek Anaszewski
Date: Wed Apr 24 2019 - 14:14:49 EST
Pavel,
On 4/24/19 3:49 PM, Pavel Machek wrote:
On Wed 2019-04-17 22:54:17, Jacek Anaszewski wrote:
Add common LED color identifiers.
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>
Cc: Baolin Wang <baolin.wang@xxxxxxxxxx>
Cc: Pavel Machek <pavel@xxxxxx>
Cc: Dan Murphy <dmurphy@xxxxxx>
Cc: Daniel Mack <daniel@xxxxxxxxxx>
Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
Cc: Oleh Kravchenko <oleg@xxxxxxxxxx>
Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Cc: Simon Shields <simon@xxxxxxxxxxxxx>
---
include/dt-bindings/leds/common.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
index da0539490cea..d8c8c38700bd 100644
--- a/include/dt-bindings/leds/common.h
+++ b/include/dt-bindings/leds/common.h
@@ -56,4 +56,15 @@
#define LED_FUNCTION_WLAN "wlan"
#define LED_FUNCTION_WPS "wps"
+/* Standard LED colors */
+#define LED_COLOR_ID_WHITE 0
+#define LED_COLOR_ID_RED 1
+#define LED_COLOR_ID_GREEN 2
+#define LED_COLOR_ID_BLUE 3
+#define LED_COLOR_ID_AMBER 4
+#define LED_COLOR_ID_VIOLET 5
+#define LED_COLOR_ID_YELLOW 6
+#define LED_COLOR_ID_IR 7
+#define LED_COLOR_ID_COUNT 8
The "_COUNT" define confused me. I was trying to figure out what color
it is. We sometimes have "_MAX" in that meaning.
Ack.
Probably can be merged with previous patch?
Ack.
--
Best regards,
Jacek Anaszewski