Re: [PATCH] iommu/amd: flush not present cache in iommu_map_page

From: Tom Murphy
Date: Wed Apr 24 2019 - 12:25:45 EST


On Wed, Apr 24, 2019 at 4:55 PM Joerg Roedel <joro@xxxxxxxxxx> wrote:
>
> On Wed, Apr 24, 2019 at 07:58:19AM -0700, Christoph Hellwig wrote:
> > I'd be tempted to do that. But lets just ask Joerg if he has
> > any opinion..
>
> The reason was that it is an unlikely path, as hardware implementations
> are not allowed to set this bit. It is purely for emulated AMD IOMMUs.
> I have not measured whether this annotation has any performance
> benefit, but I find it more readable at least.

In that case I will keep it in.

>
> Regards,
>
> Joerg
>
> PS: Why did you drop me from the Cc list of the previous replies?