Re: [PATCH] spi: stm32-qspi: manage the get_irq error case

From: Ludovic BARRE
Date: Wed Apr 24 2019 - 11:36:12 EST




On 4/24/19 5:19 PM, Fabien Dessenne wrote:
During probe, check the "get_irq" error value.

Signed-off-by: Fabien Dessenne <fabien.dessenne@xxxxxx>

Acked-by: Ludovic Barre <ludovic.barre@xxxxxx>

---
drivers/spi/spi-stm32-qspi.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c
index 11a89aa..42f8e3c 100644
--- a/drivers/spi/spi-stm32-qspi.c
+++ b/drivers/spi/spi-stm32-qspi.c
@@ -574,6 +574,12 @@ static int stm32_qspi_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
+ if (irq < 0) {
+ if (irq != -EPROBE_DEFER)
+ dev_err(dev, "IRQ error missing or invalid\n");
+ return irq;
+ }
+
ret = devm_request_irq(dev, irq, stm32_qspi_irq, 0,
dev_name(dev), qspi);
if (ret) {