Re: [PATCH] tools lib traceevent: Change tag string for error

From: Leo Yan
Date: Wed Apr 24 2019 - 08:46:07 EST


On Wed, Apr 24, 2019 at 09:44:27AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Apr 24, 2019 at 08:08:29AM -0400, Steven Rostedt escreveu:
> > On Wed, 24 Apr 2019 09:38:02 +0800
> > Leo Yan <leo.yan@xxxxxxxxxx> wrote:
> >
> > > The traceevnt lib is used by perf tool, when execute 'perf test -v 6' it
> > > outputs error log on ARM64 platform:
> > >
> > > running test 33 '*:*'trace-cmd: No such file or directory
> > >
> > > [...]
> > >
> > > trace-cmd: Invalid argument
> > >
> > > The trace event parsing code originally came from trace-cmd so it keeps
> > > the tag string "trace-cmd" for errors, this easily introduces the
> > > impression that perf tool launches trace-cmd command for trace event
> > > parsing, but in fact the related parsing is accomplished by traceevent
> > > lib.
> > >
> > > This patch changes the tag string to "libtraceevent" so can avoid
> > > confusion and let users to be more easily to connect the error with
> > > traceevent lib.
> > >
> > > Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
> >
> > Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> >
> > Arnaldo,
> >
> > Can you pull this into your tree.
>
> Sure, applied.

Thanks, Steven and Arnaldo.