Re: [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts

From: Balakrishna Godavarthi
Date: Wed Apr 24 2019 - 03:08:48 EST


Hi Harish,

On 2019-04-24 12:34, Harish Bandi wrote:
Hi Balakrishna,

On 2019-04-23 22:05, Marcel Holtmann wrote:
Hi Balakrishna,

When flag HCI_QUIRK_USE_BDADDR_PROPERTY is set, we will read the
bluetooth address from dts. If the bluetooth address node is missing
from the dts we will enable it controller UNCONFIGURED state.
This patch enables the normal flow even if the BD address is missing
from the dts tree.

Signed-off-by: Balakrishna Godavarthi <bgodavar@xxxxxxxxxxxxxx>
---
net/bluetooth/hci_core.c | 2 --
1 file changed, 2 deletions(-)

can I get an ACK for this one?

Regards

Marcel

nit: it would be better if we print error message, if bd address missing in dts.

tested 20 times with bd address missing in dts.
tested 20 times with bd address available in dts.

Tested-by: Harish Bandi <c-hbandi@xxxxxxxxxxxxxx>


Thanks,
Harish

Thanks for testing will note this improvement and send an incremental patch.

--
Regards
Balakrishna.