Re: [PATCH v3 3/3] RISC-V: Access CSRs using CSR numbers

From: Christoph Hellwig
Date: Wed Apr 24 2019 - 02:30:48 EST


On Mon, Apr 15, 2019 at 09:37:27AM +0000, Anup Patel wrote:
> We should prefer accessing CSRs using their CSR numbers because:
> 1. It compiles fine with older toolchains.
> 2. We can use latest CSR names in #define macro names of CSR numbers
> as-per RISC-V spec.
> 3. We can access newly added CSRs even if toolchain does not recognize
> newly addes CSRs by name.
>
> Signed-off-by: Anup Patel <anup.patel@xxxxxxx>

Looks fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>