Re: [PATCH] kernel/workqueue: Verify alloc_workqueue() argument list consistency

From: Bart Van Assche
Date: Mon Apr 15 2019 - 13:09:52 EST


On Tue, 2019-03-19 at 10:40 -0700, Bart Van Assche wrote:
+AD4 This patch avoids that gcc reports the following warning when building
+AD4 with W+AD0-1:
+AD4
+AD4 kernel/workqueue.c:4250:2: warning: function alloc+AF8-workqueue might be a candidate for gnu+AF8-printf format attribute +AFs--Wsuggest-attribute+AD0-format+AF0
+AD4 vsnprintf(wq-+AD4-name, sizeof(wq-+AD4-name), fmt, args)+ADs
+AD4
+AD4 Cc: Lai Jiangshan +ADw-jiangshanlai+AEA-gmail.com+AD4
+AD4 Cc: Alexander Duyck +ADw-alexander.h.duyck+AEA-linux.intel.com+AD4
+AD4 Cc: Dan Williams +ADw-dan.j.williams+AEA-intel.com+AD4
+AD4 Fixes: 669de8bda87b (+ACI-kernel/workqueue: Use dynamic lockdep keys for workqueues+ACI)
+AD4 Signed-off-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4
+AD4 ---
+AD4 include/linux/workqueue.h +AHw 1
+AD4 1 file changed, 1 insertion()
+AD4
+AD4 diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
+AD4 index d59525fca4d3..30737b5183c0 100644
+AD4 --- a/include/linux/workqueue.h
+AD4 +++b/include/linux/workqueueh4046 +404,7 +AEAAQA extern struct workqueue+AF8-struct +ACo-system+AF8-freezable+AF8-power+AF8-efficient+AF8-wq+ADs
+AD4 +ACo RETURNS:
+AD4 +ACo Pointer to the allocated workqueue on success, +ACU-NULL on failure.
+AD4 +ACo-/
+AD4 +AF8AXw-printf(1, 4)
+AD4 struct workqueue+AF8-struct +ACo-alloc+AF8-workqueue(const char +ACo-fmt,
+AD4 unsigned int flags,
+AD4 int max+AF8-active, ...)+ADs

Ping?

Bart.