Re: [PATCH V5 3/3] hwmon: pwm-fan: Add RPM support via external interrupt

[Guenter Roeck]

On 4/12/19 6:35 AM, Stefan Wahren wrote:
> Hi Enrico,
>
> On 12.04.19 15:15, Enrico Weigelt, metux IT consult wrote:
> > On 11.04.19 15:30, Stefan Wahren wrote:
> > > This adds RPM support to the pwm-fan driver in order to use with
> > > fancontrol/pwmconfig. This feature is intended for fans with a tachometer
> > > output signal, which generate a defined number of pulses per revolution.
> > Wouldn't it be better to have a CONFIG_* flag for keeping the kernel
> > image size smaller when this feature isn't needed ?
>
> i compared the kernel module size in linux-next for ARM without and with
> this patch:
> without patch: 12088 bytes
> with patch: 14292 bytes
>
> I don't think it is worth the trouble.

Agreed. This would end up being a mess, with lots of configuration options
in various drivers. Please don't start it.

Guenter