Re: WARNING in untrack_pfn

From: Julia Lawall
Date: Fri Apr 12 2019 - 09:21:55 EST




On Fri, 12 Apr 2019, Pavel Machek wrote:

> On Fri 2019-04-12 04:42:01, syzbot wrote:
> > syzbot has bisected this bug to:
> >
> > commit c68729119f4d2993bec3c9cb999ad76de5aeddba
> > Author: Julia Lawall <Julia.Lawall@xxxxxxx>
> > Date: Sat Jul 15 09:58:19 2017 +0000
> >
> > leds: tlc591xx: add missing of_node_put
> >
> > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12cda0f3200000
> > start commit: 23203e3f Merge branch 'akpm' (patches from Andrew)
> > git tree: upstream
> > final crash: https://syzkaller.appspot.com/x/report.txt?x=11cda0f3200000
> > console output: https://syzkaller.appspot.com/x/log.txt?x=16cda0f3200000
> > kernel config: https://syzkaller.appspot.com/x/.config?x=861a3573f4e78ba1
> > dashboard link: https://syzkaller.appspot.com/bug?extid=e1a4f80c370d2381e49f
> > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17836d15400000
> >
> > Reported-by: syzbot+e1a4f80c370d2381e49f@xxxxxxxxxxxxxxxxxxxxxxxxx
> > Fixes: c68729119f4d ("leds: tlc591xx: add missing of_node_put")
> >
> > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
>
> Can you revert c68729119f4d2993bec3c9cb999ad76de5aeddba on master and
> see if it fixes the problem? Because this is hard to believe...

Likewise, it seems hard to believe that the change is a problem. But
could the problem be elsewhere and triggered by this code?

julia

>
> Pavel
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>