Re: [PATCH 2/2] net-sysfs: Fix memory leak in netdev_register_kobject

From: Andy Shevchenko
Date: Fri Apr 12 2019 - 04:38:43 EST


On Fri, Apr 12, 2019 at 04:36:34PM -0400, Wang Hai wrote:

> +error_register:
> + device_del(dev);
> +error_device_add:
> + kfree_const(dev->kobj.name);
> return error;

When put_device() will be called on this it will go to double free (in case of
dynamically allocated dev->kobj.name.

Al Viro and me suggested earlier that the correct fix is to call put_device()
in a places where it is appropriate.

--
With Best Regards,
Andy Shevchenko