Re: [RFC PATCH v3 3/4] x86: Use HYPERVISOR_CALLBACK_VECTOR for acrn_guest upcall vector

[Zhao, Yakui]

On 2019å04æ11æ 21:55, Borislav Petkov wrote:
> On Wed, Apr 10, 2019 at 03:57:08PM +0800, Zhao, Yakui wrote:
> > It is used to avoid that one function declaration has no definition
> > when asm/acrnhyper.h is included and ACRN_GUEST is not enabled.
>
> And that is a problem because...?

This is not a problem.
I take a look at the header file of mshyperv.h and xen/events.h.
It seems that they have no such extra conditional definition.
To follow the same style, I will remove it.

> > Do you have any suggestion about the header order?
> > > linux/ path includes still need to come first, of course.
>
> As said above:
>
> linux/ path first, then asm/
>
> Feel free to look around the tree for inspiration :)

I take a look at the file of vwmare.c/mshyperv.c under the directory of 
arch/x86/kernel/cpu. It seems that the header file only follows the 
order of: linux/ path first and then asm/.

Anyway, I will follow your idea in previous email and use the alphabetic 
order.

Thanks
>