Re: [PATCH v3 2/9] kbuild: Support for Symbols.list creation

[Joe Lawrence]

On 4/11/19 5:18 AM, Artem Savkov wrote:
> On Wed, Apr 10, 2019 at 11:50:51AM -0400, Joe Lawrence wrote:
> > -clean: archclean vmlinuxclean
> > +klpclean:
> > +	$(Q) rm -f $(objtree)/Symbols.list
>
> nit: $(SLIST) can be used here.
>
> > +clean: archclean vmlinuxclean klpclean
> >   
> >   # mrproper - Delete all generated files, including .config
> >   #
> > diff --git a/samples/livepatch/Makefile b/samples/livepatch/Makefile
> > index 2472ce39a18d..8b9b42a258ad 100644
> > --- a/samples/livepatch/Makefile
> > +++ b/samples/livepatch/Makefile
> > @@ -1,3 +1,4 @@
> > +LIVEPATCH_livepatch-sample := y
> >   obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-sample.o
> >   obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-mod.o
> >   obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-fix1.o
> > diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> > index 76ca30cc4791..ca76bd2080f0 100644
> > --- a/scripts/Makefile.build
> > +++ b/scripts/Makefile.build
> > @@ -246,6 +246,11 @@ cmd_gen_ksymdeps = \
> >   	$(CONFIG_SHELL) $(srctree)/scripts/gen_ksymdeps.sh $@ >> $(dot-target).cmd
> >   endif
> >   
> > +ifdef CONFIG_LIVEPATCH
> > +cmd_livepatch = $(if $(LIVEPATCH_$(basetarget)),		\
> > +	$(shell touch $(MODVERDIR)/$(basetarget).livepatch))
> > +endif
> > +
> >   define rule_cc_o_c
> >   	$(call cmd,checksrc)
> >   	$(call cmd_and_fixdep,cc_o_c)
> > @@ -280,6 +285,7 @@ $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE
> >   $(single-used-m): $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE
> >   	$(call cmd,force_checksrc)
> >   	$(call if_changed_rule,cc_o_c)
> > +	$(call cmd_livepatch)
>
> nit: maybe use "cmd,livepatch" to be consistent with the other call of
> this function.

Both of these make sense, thanks Artem.

-- Joe