Re: [PATCH linux] objtool: fix pkg-config query in case of cross-compilation

[Rolf Eike Beer]

Am Donnerstag, 11. April 2019, 11:26:12 CEST schrieb Nicolas Dichtel:
> Le 11/04/2019 Ã 10:52, Rolf Eike Beer a Ãcrit :
> > Am Donnerstag, 11. April 2019, 10:39:40 CEST schrieb Nicolas Dichtel:
> >> In case of cross-compilation, there may be two pkg-config tools, one for
> >> the host and one for the target. Enable to override the default name.
> >> 
> >> Fixes: 056d28d135bc ("objtool: Query pkg-config for libelf location")
> >> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
> > 
> > If you do that, you have to fix a lot of other places, too. This starts in
> > scripts/kconfig/ and also includes e.g. tools/testing/.
> > 
> > Usually you have pkg-config for host and ${target_platform}-pkg-config for
> > the
> My use case was for buildroot, which define pkg-config and host-pkgconf. In
> fact, I've just seen that a buildroot patch was accepted for this problem:
> https://patchwork.ozlabs.org/patch/1081379/

I agree that it makes sense to have both host and target pkg-config 
configurable. But IMHO that must happen in a central place (i.e. ./Makefile), 
and it has to be used everywhere. Currently PKG_CONFIG is defined at multiple 
places, sometimes host, sometimes target, and often pkg-config is called 
directly, also mixing both usages.

So, IMHO, if you want to fix this: fix it once and for all in the whole 
kernel, not just one place. What I have introduced was just the same as 
kconfig is using to find the dependencies for some of the *config variants, so 
this usecase would break for you anyway, although I don't think anyone in 
buildroot will notice this.

Eike
-- 
Rolf Eike Beer, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Gothaer Platz 3, 37083 GÃttingen, Germany
Sitz der Gesellschaft: GÃttingen, Amtsgericht GÃttingen HR B 3160
GeschÃftsfÃhrung: Heike Jordan, Dr. Uwe Kracke â Ust-IdNr.: DE 205 198 055

emlix - smart embedded open source

Attachment: signature.asc
Description: This is a digitally signed message part.