Re: [PATCH v2 2/5] arm64, mm: Move generic mmap layout functions to mm

[Alexandre Ghiti]

On 04/10/2019 08:27 PM, Kees Cook wrote:
> On Wed, Apr 10, 2019 at 12:33 AM Alexandre Ghiti <alex@xxxxxxxx> wrote:
> > On 04/10/2019 08:59 AM, Christoph Hellwig wrote:
> > > On Thu, Apr 04, 2019 at 01:51:25AM -0400, Alexandre Ghiti wrote:
> > > > - fix the case where stack randomization should not be taken into
> > > >     account.
> > > Hmm.  This sounds a bit vague.  It might be better if something
> > > considered a fix is split out to a separate patch with a good
> > > description.
> > Ok, I will move this fix in another patch.
> Yeah, I think it'd be best to break this into a few (likely small) patches:
> - update the compat case in the arm64 code
> - fix the "not randomized" case
> - move the code to mm/ (line-for-line identical for easy review)
>
> That'll make it much easier to review (at least for me).
>
> Thanks!

Sorry about that, I'm working on it.

Thanks,

Alex