Re: [RFC patch 20/41] backtrace-test: Simplify stack trace handling

From: Josh Poimboeuf
Date: Wed Apr 10 2019 - 22:47:53 EST


On Wed, Apr 10, 2019 at 12:28:14PM +0200, Thomas Gleixner wrote:
> Replace the indirection through struct stack_trace by using the storage
> array based interfaces.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
> kernel/backtracetest.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> --- a/kernel/backtracetest.c
> +++ b/kernel/backtracetest.c
> @@ -48,19 +48,14 @@ static void backtrace_test_irq(void)
> #ifdef CONFIG_STACKTRACE
> static void backtrace_test_saved(void)
> {
> - struct stack_trace trace;
> unsigned long entries[8];
> + unsigned int nent;

"Nent" isn't immediately readable to my eyes. How about just good old
"nr_entries"? (for this patch and all the others)

--
Josh