Re: [RFC PATCH hubcap] orangefs: orangefs_file_open() can be static

From: Joe Perches
Date: Wed Apr 10 2019 - 22:15:10 EST


On Thu, 2019-04-11 at 09:58 +0800, kbuild test robot wrote:
> Fixes: 9a959aaffd70 ("orangefs: remember count when reading.")

Making something static likely does not warrant a "Fixes:" tag

> Signed-off-by: kbuild test robot <lkp@xxxxxxxxx>
> ---
> file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/orangefs/file.c b/fs/orangefs/file.c
> index d198af9..01d0db6 100644
> --- a/fs/orangefs/file.c
> +++ b/fs/orangefs/file.c
> @@ -571,7 +571,7 @@ static int orangefs_lock(struct file *filp, int cmd, struct file_lock *fl)
> return rc;
> }
>
> -int orangefs_file_open(struct inode * inode, struct file *file)
> +static int orangefs_file_open(struct inode * inode, struct file *file)
> {
> file->private_data = NULL;
> return generic_file_open(inode, file);