Re: [PATCH v3 3/9] livepatch: Add klp-convert tool

From: Joe Lawrence
Date: Wed Apr 10 2019 - 14:22:25 EST


On Wed, Apr 10, 2019 at 11:50:52AM -0400, Joe Lawrence wrote:
>
> [ ... snip ... ]
>
> diff --git a/scripts/livepatch/klp-convert.c b/scripts/livepatch/klp-convert.c
> new file mode 100644
> index 000000000000..62bd26941081
> --- /dev/null
> +++ b/scripts/livepatch/klp-convert.c
>
> [ ... snip ... ]
>
> + if (argc != 4) {
> + WARN("Usage: %s <Symbols.list> <input.ko> <out.ko>", argv[0]);
^^^^^^^^^^
nit: since we're using .klp.o prefix, should this be "input.klp.o"

-- Joe